Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve User Settings email validation and error flow #1326

Merged

Conversation

sdirosa
Copy link
Contributor

@sdirosa sdirosa commented Nov 28, 2022

This PR solves #1281

Changes

  • In the users api:
    • added invalid_email error code when email validation fails
    • added unit test to verify whether sending an invalid email returns the new error code
  • Improved a few things in the frontend for the settings view
    • In the template, the email field's type attribute is now set to email, instead of text
    • The form will remain in editing mode when receiving errors from remote
    • The invalid_email error code will result in a message being shown under the email field

@knolleary
Copy link
Member

Thanks @sdirosa

@knolleary knolleary merged commit cdbb411 into FlowFuse:main Nov 29, 2022
@ZJvandeWeg ZJvandeWeg added this to the 1.2 milestone Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants