Fix resync maintenance release task #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The task to resync `main` to `maintenance` failed in the 1.3.0 release. This PR fixes the error by being explicit on what branch we want the `maintenance` branch to be reset to. This doesn't appear to be necessary when running the commands locally, but there must be something about how `actions/checkout` leaves things that makes this necessary when running in a GH Action. I have reproduced the error in a private repo on my personal GH account and verified this fixes it there.
hardillb
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The task to resync
maintomaintenancefailed in the 1.3.0 release.This PR fixes the error by being explicit on what branch we want the
maintenancebranch to be reset to.This doesn't appear to be necessary when running the commands locally, but there must be something about how
actions/checkoutleaves things that makes this necessary when running in a GH Action.I have reproduced the error in a private repo on my personal GH account and verified this fixes it there.