Change project type API unit tests #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pezmc
commented
Jan 31, 2023
| env: [ | ||
| { name: 'one', value: 'a' }, | ||
| { name: 'two', value: 'b' } | ||
| response.statusCode.should.equal(200) |
There was a problem hiding this comment.
Unfortunately, I couldn't find a way to assert the project is suspended as the request only returns once the project has been restarted.
There was a problem hiding this comment.
One approach would be to add some sort of internal logging to the stub driver that can be used to check what has been done to a given project. But not sure that's worth the effort at this point.
There was a problem hiding this comment.
We could spy on the audit logs actually!
There was a problem hiding this comment.
I did wonder that, but couldn't recall if the audit logging is done at that level.
knolleary
approved these changes
Feb 1, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests of the API changes for #1610.
Best viewed with ?w=1 due to indent changes in the tests.
Pre-cursor to #1623