Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Team slug check #1655

Merged
merged 3 commits into from
Feb 8, 2023
Merged

Team slug check #1655

merged 3 commits into from
Feb 8, 2023

Conversation

knolleary
Copy link
Member

@knolleary knolleary commented Feb 3, 2023 •
edited
Loading

Description

This adds an endpoint POST /api/v1/teams/check-slug that can be used to validate if a team slug is available for use or not.

Available returns status 200 {status: 'okay'}.
Unavailable returns status 409 { code: 'invalid_slug', error: 'Slug not available' }

The Create Team and Update Team pages have been updated to use this endpoint and feedback to the user before they try using the slug.

Related Issue(s)

#1609

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@knolleary knolleary linked an issue Feb 3, 2023 that may be closed by this pull request
Async Team Slug Check #1609
Closed
@knolleary knolleary requested a review from Pezmc February 6, 2023 17:36
Pezmc
Pezmc reviewed Feb 7, 2023
View reviewed changes
forge/routes/api/team.js Outdated Show resolved Hide resolved
@knolleary knolleary mentioned this pull request Feb 8, 2023
Open
@knolleary @Pezmc
Update forge/routes/api/team.js
338695a 
Co-authored-by: Pez Cuckow <email@pezcuckow.com>
@knolleary knolleary merged commit 49eb03a into main Feb 8, 2023
@knolleary knolleary deleted the team-slug-check branch February 8, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pezmc Pezmc Pezmc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Async Team Slug Check
2 participants
@knolleary @Pezmc