Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404: Fix broken link #1662

Merged
merged 1 commit into from
Feb 6, 2023
Merged

404: Fix broken link #1662

merged 1 commit into from
Feb 6, 2023

Conversation

ZJvandeWeg
Copy link
Member

Description

Fixes broken link

Related Issue(s)

There's more I'm fixing today, I wonder if it's possible to check for broken internal links with a GH action?

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@knolleary
Copy link
Member

We do have the action for checking broken links - https://github.com/flowforge/flowforge/actions/runs/4102847773

We need to identify why it didn't pickup this broken link in the first place.

@knolleary knolleary merged commit 08aef54 into main Feb 6, 2023
@knolleary knolleary deleted the zj-fix-broken-link branch February 6, 2023 10:52
@github-actions github-actions bot mentioned this pull request Feb 6, 2023
11 tasks
@knolleary
Copy link
Member

Reviewed too quickly - the link is still broken. Fix incoming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants