Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to activate a new snapshot on creation #1705

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

Steve-Mcl
Copy link
Contributor

@Steve-Mcl Steve-Mcl commented Feb 14, 2023

Description

Adds a checkbox to permit setting a newly created snapshot as the target snapshot

Demo:

create-snapshot-and-set-target.mp4

Audit Logs showing activities of above operations...

image

Related Issue(s)

Closes #1527

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • [-] Documentation has been updated
  • [-] Changes flowforge.yml?
    • [-] Issue/PR raised on flowforge/helm to update ConfigMap Template
    • [-] Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • [-] Backport needed? -> add the backport label
  • [-] Includes a DB migration? -> add the area:migration label

@Steve-Mcl
Copy link
Contributor Author

@joepavitt, added you for review (early - while I check see what docs need updating)

@Steve-Mcl
Copy link
Contributor Author

@joepavitt - I am actually ok with the docs as they read now: https://flowforge.com/docs/user/concepts/#device

If you agree, we can switch this to "Ready for review"

@joepavitt
Copy link
Contributor

Agreed

@Steve-Mcl Steve-Mcl linked an issue Feb 14, 2023 that may be closed by this pull request
@Steve-Mcl Steve-Mcl marked this pull request as ready for review February 14, 2023 17:51
@Steve-Mcl
Copy link
Contributor Author

Ready for review.

@joepavitt joepavitt merged commit 1f732bd into main Feb 15, 2023
@joepavitt joepavitt deleted the set-new-snapshot-as-target branch February 15, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optionally set snapshot as target at creation
2 participants