Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Last Seen" status pill #1710

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Add "Last Seen" status pill #1710

merged 2 commits into from
Feb 15, 2023

Conversation

joepavitt
Copy link
Contributor

@joepavitt joepavitt commented Feb 15, 2023 •
edited
Loading

Description

Missed adding the new status pill onto the Project > Deployments page. This adds it in.

Screenshot 2023-02-15 at 15 03 27

Related Issue(s)

Closes #1709

Checklist

  • I have read the contribution guidelines
  • [-] Suitable unit/system level tests have been added and they pass
  • [-] Documentation has been updated
    • [-] Upgrade instructions
    • [-] Configuration details
    • [-] Concepts
  • [-] Changes flowforge.yml?
    • [-] Issue/PR raised on flowforge/helm to update ConfigMap Template
    • [-] Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • [-] Backport needed? -> add the backport label
  • [-] Includes a DB migration? -> add the area:migration label

@joepavitt joepavitt requested a review from Pezmc February 15, 2023 15:03
Pezmc
Pezmc approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@Pezmc Pezmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two non-blocking comments

@joepavitt joepavitt merged commit 9c8a4a5 into main Feb 15, 2023
@joepavitt joepavitt deleted the fix-1709-device-status branch February 15, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pezmc Pezmc Pezmc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Device Status missing
2 participants
@joepavitt @Pezmc