Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the router-link name for ProjectLink component #1714

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

joepavitt
Copy link
Contributor

Description

https://d.pr/v/u7qcC7 flagged that when devices are attached to a project, the project name is not showing. Upon investigation, this was introduced in #1711 where we renamed the view "ProjectDeployments" to "ProjectInstances" and so when rendering the ProjectLink component, it was failing to render because it couldn't find the destination page (still pointing to ProjectDeployments).

Checklist

  • I have read the contribution guidelines
  • [-] Suitable unit/system level tests have been added and they pass
  • [-] Documentation has been updated
    • [-] Upgrade instructions
    • [-] Configuration details
    • [-] Concepts
  • [-] Changes flowforge.yml?
    • [-] Issue/PR raised on flowforge/helm to update ConfigMap Template
    • [-] Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • [-] Backport needed? -> add the backport label
  • [-] Includes a DB migration? -> add the area:migration label

@hardillb hardillb merged commit b41a003 into main Feb 16, 2023
@hardillb hardillb deleted the fix-device-projectname branch February 16, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants