Ensure telemetry is enabled for licensed installs #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knolleary
reviewed
Feb 23, 2023
| @@ -26,6 +27,7 @@ module.exports = async function (app) { | |||
| } | |||
|
|
|||
| if (request.session.User.admin) { | |||
| response['platform:licensed'] = isLicensed | |||
There was a problem hiding this comment.
Not 100% sure about including this here as we already have the /api/v1/admin/license end point that returns license details.
That said, we can move forward with this as-is and iterate if needed.
knolleary
reviewed
Feb 23, 2023
| @@ -22,6 +22,8 @@ Settings section of the platform UI. | |||
| It is also possible to disable in the `flowforge.yml` configuration file. This | |||
| overrides whatever option is set in the Admin Settings UI. | |||
|
|
|||
| **IMPORTANT: Licensed installations cannot disable telemetry** | |||
There was a problem hiding this comment.
Good first iteration, but I think we need to word this slightly differently as we don't talk about 'installations' generally.
We will need to document the behaviours around licensing in general with the changes coming in the other tasks. So lets make sure we do a 'big picture' review of the licensing docs as part of this work once we have the full set of behaviours defined.
knolleary
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Outdated (click to reveal)
pre 2023/02/22
telemetry:enabledsetting is always true if product is licensedplatform:licensedboolean setting for the following 2 items...Updated 2023/02/22
telemetry:enabledsetting is always true if product is licensed (both client and server side)platform:licensedboolean (readonly) settingplatform:licensedsetting to hide telemetry setting checkbox and parent group titleRelated Issue(s)
#1640
Checklist
flowforge.yml?flowforge/helmto update ConfigMap Templateflowforge/CloudProjectto update values for Staging/ProductionLabels
backportlabelarea:migrationlabel