Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First pass at AWS K8s install clean up #1753

Merged
merged 5 commits into from
Apr 26, 2023
Merged

First pass at AWS K8s install clean up #1753

merged 5 commits into from
Apr 26, 2023

Conversation

hardillb
Copy link
Contributor

Description

  • Use a consistent cluster name
  • Remove section on setting up container registry (no longer needed as containers on Docker hub)

Related Issue(s)

#1752

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb added this to the 1.5 milestone Feb 24, 2023
@hardillb hardillb self-assigned this Feb 24, 2023
@hardillb hardillb requested a review from robmarcer April 26, 2023 14:00
@hardillb hardillb marked this pull request as ready for review April 26, 2023 14:00
robmarcer
robmarcer approved these changes Apr 26, 2023
View reviewed changes
docs/install/kubernetes/aws.md Outdated
@@ -88,27 +80,71 @@ nodeGroups:

Add oidc provider for the Load Balancer and IAM roles
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 'oidc' should be 'OIDC'.

docs/install/kubernetes/aws.md Outdated Show resolved Hide resolved
docs/install/kubernetes/aws.md Outdated Show resolved Hide resolved
hardillb and others added 3 commits April 26, 2023 15:28
@hardillb @robmarcer
Update docs/install/kubernetes/aws.md
db40a2b 
Co-authored-by: Rob Marcer <92092324+robmarcer@users.noreply.github.com>
@hardillb @robmarcer
Update docs/install/kubernetes/aws.md
48b2bfe 
Co-authored-by: Rob Marcer <92092324+robmarcer@users.noreply.github.com>
@hardillb
Fix the extra bits
fc5e9f3
@hardillb hardillb merged commit 96de454 into main Apr 26, 2023
@hardillb hardillb deleted the aws-eks-fix-docs branch April 26, 2023 15:02
@github-actions github-actions bot mentioned this pull request Apr 26, 2023
Merged
11 tasks
hardillb added a commit that referenced this pull request Apr 26, 2023
@hardillb
Merge pull request #2049 from flowforge/backport-1753
91375b5 
First pass at AWS K8s install clean up (backport #1753)
@hardillb hardillb mentioned this pull request May 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robmarcer robmarcer robmarcer approved these changes

Assignees

@hardillb hardillb

Labels
backport
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hardillb @robmarcer