Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce fake log entries for the stub driver #1771

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Introduce fake log entries for the stub driver #1771

merged 1 commit into from
Mar 6, 2023

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented Mar 6, 2023

Description

Previously this screen was always blank when using stub driver.

Screenshot 2023-03-06 at 17 01 14

Related Issue(s)

None

Checklist

  • I have read the contribution guidelines
  • [-] Suitable unit/system level tests have been added and they pass
  • [-] Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • [-] Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@Pezmc Pezmc requested review from knolleary and hardillb March 6, 2023 16:02
hardillb
hardillb approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@hardillb hardillb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by Captain Black

@Pezmc Pezmc merged commit 05fe434 into main Mar 6, 2023
@Pezmc Pezmc deleted the feat-stub-logs branch March 6, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardillb hardillb hardillb approved these changes

@knolleary knolleary Awaiting requested review from knolleary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Pezmc @hardillb