Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependency #1774

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Remove unused dependency #1774

merged 1 commit into from
Mar 7, 2023

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented Mar 7, 2023

It seems like this dependency isn't used, if tests pass, we can remove it entirely rather than updating it (#1754)

@Pezmc Pezmc requested a review from Steve-Mcl March 7, 2023 12:49
Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does appear to be unused - but Joe may use it from command line?

Happy to remove if you are Pez - will leave for you to commit (or for @joepavitt to comment)

@Pezmc
Copy link
Contributor Author

Pezmc commented Mar 7, 2023

Thanks!

We can use npx start-server-and-test if it's need locally for CLI work!

@Pezmc Pezmc merged commit 7996a73 into main Mar 7, 2023
@Pezmc Pezmc deleted the chore-remove-unused-dependency branch March 7, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants