-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow user to delete self #1787
Conversation
So long as: - user is NOT last admin - user is NOT last owner of a team
docs/admin/user_management.md
Outdated
@@ -20,4 +20,10 @@ Users can only be removed if they don't own any teams and projects. As such the | |||
user should delete any projects and ensure their teams have alternative owners. They | |||
can either do this themselves or an Admin user can do it for them. | |||
|
|||
Once all teams and projects are removed, the user can be removed using the option in the "Edit User" dialog. | |||
### Deleting your own account |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section is for admin users - not where regular users will go looking for help.
We probably want to add a bit to docs/cloud/README.md
as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated in b503d52
@@ -19,7 +19,10 @@ | |||
</div> | |||
</template> | |||
<template v-else> | |||
<ff-button @click="startEdit">Edit</ff-button> | |||
<div class="flex space-x-4"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way this is presented, it feels like a 'cancel' button next to 'edit'.
I think it should appear more consistent with the 'Delete Project' button under Project/Instance settings:
The text can also say something about needing to delete/transfer team ownership as well. We shouldn't let the user try to delete their account if we know it's going to fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated in 7c26d2c
Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
tests failing on untouched / unrelated issue:
|
@Steve-Mcl Fix in #1814 |
@knolleary @hardillb I believe I have addressed all of the issues. Please re-review at your convenience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Description
user
Screenshots
Deleting last admin
Deleting sole team owner
Related Issue(s)
#1767
Checklist
Labels
backport
labelarea:migration
label