Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit Log UI Improvements #1805

Merged
merged 7 commits into from
Mar 15, 2023
Merged

Audit Log UI Improvements #1805

merged 7 commits into from
Mar 15, 2023

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented Mar 13, 2023 •
edited
Loading

Description

Before

Screenshot 2023-03-13 at 15 02 07

After

Screenshot 2023-03-13 at 15 15 17

Before

Screenshot 2023-03-13 at 15 01 59

After

Screenshot 2023-03-13 at 15 15 25

Before

Screenshot 2023-03-13 at 15 01 51

After

Screenshot 2023-03-13 at 15 15 44

Before

Screenshot 2023-03-13 at 15 01 44

After

Screenshot 2023-03-13 at 15 15 55

Related Issue(s)

Fix #1800

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@knolleary
Copy link
Member

knolleary commented Mar 13, 2023 •
edited
Loading

For this scenario:

image

At a certain width, could we switch to a vertical stack - filters above the table rather than to the side?

@Pezmc
Copy link
Contributor Author

Pezmc commented Mar 13, 2023

@knolleary Have asked @joepavitt to finish up this PR while I work on the destroy application page.

@joepavitt joepavitt self-assigned this Mar 13, 2023
@joepavitt
Copy link
Contributor

improvement with the mobile view coming in at 1024px:

Screen.Recording.2023-03-14.at.11.56.43.mov

Will now make some further tweaks in the rows themselves so they look better even at mobile level

@joepavitt
Copy link
Contributor

Now using grid-area - looks good all the way down to mobile (apart from the filters, but even they don't look terrible). Notice that the author part moves up inline with the time, and then the main content sits on a row on it's own.

Screen.Recording.2023-03-15.at.13.12.46.mov

@joepavitt
Copy link
Contributor

Will add @knolleary as reviewer given that both @Pezmc and I actively did the work.

@joepavitt joepavitt marked this pull request as ready for review March 15, 2023 13:15
knolleary
knolleary reviewed Mar 15, 2023
View reviewed changes
Copy link
Member

@knolleary knolleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff all around. Thanks @Pezmc @joepavitt

@knolleary knolleary merged commit 6c63d6c into main Mar 15, 2023
@knolleary knolleary deleted the fix-1800-audit-log-ui branch March 15, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knolleary knolleary knolleary approved these changes

Assignees

@joepavitt joepavitt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audit Log UX glitches
3 participants
@Pezmc @knolleary @joepavitt