Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Instances: Remove Application > Remote Instances list #1827

Merged
merged 7 commits into from
Mar 14, 2023

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented Mar 14, 2023

Description

Removes the remote instances list from the Application > Instances page entirely.

Before

Screenshot 2023-03-14 at 16 14 15

Of note: This explanation dialog no longer exists and has no replacement @joepavitt

Screenshot 2023-03-14 at 16 14 08

After

Application > Instances

Screenshot 2023-03-14 at 16 14 28

New loading state for Application pages

Screenshot 2023-03-14 at 15 56 46

Improved loading state for Instance pages

Screenshot 2023-03-14 at 16 16 46

Related Issue(s)

Fix #1825
Fix #1824

Checklist

  • I have read the contribution guidelines
  • [-] Suitable unit/system level tests have been added and they pass
  • [-] Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • [-] Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@joepavitt
Copy link
Contributor

re: the dialog now being removed, worth moving this to be accesible on the Instance > Devices table?

@Pezmc
Copy link
Contributor Author

Pezmc commented Mar 14, 2023

@joepavitt If you have a proposal as to where, it doesn't fit well with the current shared header design:

Screenshot 2023-03-14 at 16 53 31

@joepavitt
Copy link
Contributor

It does not - right you are. I'll have a play when renaming the "Remote Instances" option.

@Pezmc Pezmc merged commit 28d2229 into main Mar 14, 2023
@Pezmc Pezmc deleted the fix-1825-application-devices branch March 14, 2023 16:07
@knolleary knolleary mentioned this pull request Mar 14, 2023
@joepavitt
Copy link
Contributor

@Pezmc this claims to have fixed #1826 - which isn't related, can you update to the correct issue please, and I'll reopen #1826

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants