Relabel Project Types to Instance Types in UI #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Investigating UI test failures. Thought I had handled this. |
|
Tests (hopefully) fixed. Overlooked the fact they use kebab-case ( |
|
The final failing test is due to an update to cypress. @joepavitt has already merged the fix via #1835 |
|
Merged main into this branch and all tests are passing. Good for review and merge. |
Pezmc
reviewed
Mar 15, 2023
| @@ -0,0 +1,159 @@ | |||
| <template> | |||
There was a problem hiding this comment.
Assuming this file is not new and GitHub hasn't tracked the move
There was a problem hiding this comment.
Correct - I think the combination of rename and the number of changes of Project->Instance has exceeded what git thinks is a move and edit.
Pezmc
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1689
This wasn't originally in scope, but having started to write the doc updates for introducing Instances, the Project Type concept stuck out a lot.
This PR is a cosmetic update to the front-end to reference Instance Type instead of Project Type. In some components I've also updated internal variables to be
instancerather thanprojectwhere the changes are not too extensive. Some views need more detailed going through so I've elected to skip for now.