Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Instances: Team Device Bug Fixes #1841

Merged
merged 7 commits into from
Mar 15, 2023
Merged

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented Mar 15, 2023

Description

  • Fixes unassigning a device from an instance on the team table
  • Adds a loading state to the assign device dialog
  • Renames DeviceAssignInstanceDialog.vue
  • Adds test coverage of assign and unassign
Screen.Recording.2023-03-15.at.12.36.43.mov

Related Issue(s)

Fixes #1838

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • [-] Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • [-] Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@Pezmc Pezmc requested a review from knolleary March 15, 2023 12:16
@Pezmc
Copy link
Contributor Author

Pezmc commented Mar 15, 2023

Looking into failing tests

Copy link
Member

@knolleary knolleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending test failure resolution

@knolleary knolleary merged commit 5d0fded into main Mar 15, 2023
@knolleary knolleary deleted the fix-1838-team-devices branch March 15, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Team Devices table doesn't update properly when adding/removing devices from instance
2 participants