Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Add Instance" placeholder & improve button size consistency #1842

Merged
merged 5 commits into from
Mar 15, 2023
Merged

"Add Instance" placeholder & improve button size consistency #1842

merged 5 commits into from
Mar 15, 2023

Conversation

joepavitt
Copy link
Contributor

Description

  • Did a sweep of the primary action buttons and removed usage of size="small"
    • Update some use of FormRowHeader to SectionTopMenu for better sizing and layout too
  • Added the "Add Instance" button, which for now opens a Dialog to explain it's "Coming Soon", with detail on how to add new instances at the moment (via "Add Application")
Screen.Recording.2023-03-15.at.12.31.09.mov

Related Issue(s)

Closes #1823

Checklist

  • I have read the contribution guidelines
  • [-] Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions

@knolleary knolleary merged commit 60fb7c3 into main Mar 15, 2023
@knolleary knolleary deleted the 1823-add-instance-btn branch March 15, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knolleary knolleary Awaiting requested review from knolleary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Action: “Add Instance” button to just show Dialog for “Coming soon...”
2 participants
@joepavitt @knolleary