Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HTTPS docs to include updating the base_url #1855

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Update HTTPS docs to include updating the base_url #1855

merged 1 commit into from
Mar 20, 2023
+1 −1

Conversation

hardillb
Copy link
Contributor

Description

The docker install docs are missing an important change to ensure the base_url starts with https:// when enabling certificates.

Related Issue(s)

part of #1854

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb added this to the 1.6 milestone Mar 17, 2023
@hardillb hardillb requested a review from robmarcer March 17, 2023 16:15
@hardillb hardillb self-assigned this Mar 17, 2023
@hardillb hardillb merged commit 152ee7e into main Mar 20, 2023
@hardillb hardillb deleted the hardillb-patch-2 branch March 20, 2023 17:20
@github-actions github-actions bot mentioned this pull request Mar 20, 2023
Merged
11 tasks
hardillb added a commit that referenced this pull request Mar 20, 2023
@hardillb
Merge pull request #1861 from flowforge/backport-1855
b1f5994 
Update HTTPS docs to include updating the base_url (backport #1855)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robmarcer robmarcer robmarcer approved these changes

Assignees

@hardillb hardillb

Labels
backport
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hardillb @robmarcer