Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add streaming logs from device agents #1900

Merged
merged 18 commits into from
Apr 4, 2023
Merged

Add streaming logs from device agents #1900

merged 18 commits into from
Apr 4, 2023

Conversation

hardillb
Copy link
Contributor

Description

This requires MQTT device comms

Dependent on FlowFuse/device-agent#66

Related Issue(s)

#1820

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@hardillb
Add streaming logs from device agents
cd5edc8 
This requires MQTT device comms

Dependent on FlowFuse/device-agent#66
@hardillb hardillb added this to the 1.6 milestone Mar 30, 2023
@hardillb hardillb self-assigned this Mar 30, 2023
hardillb and others added 8 commits April 3, 2023 18:12
@hardillb @Steve-Mcl
Update frontend/src/pages/device/components/DeviceLog.vue
6f745aa 
Co-authored-by: Stephen McLaughlin <44235289+Steve-Mcl@users.noreply.github.com>
@hardillb @Steve-Mcl
Update frontend/src/pages/device/components/DeviceLog.vue
7a9d7c8 
Co-authored-by: Stephen McLaughlin <44235289+Steve-Mcl@users.noreply.github.com>
@hardillb @Steve-Mcl
Update frontend/src/pages/device/components/DeviceLog.vue
2606e53 
Co-authored-by: Stephen McLaughlin <44235289+Steve-Mcl@users.noreply.github.com>
@hardillb @Steve-Mcl
Update frontend/src/pages/device/components/DeviceLog.vue
cbc2765 
Co-authored-by: Stephen McLaughlin <44235289+Steve-Mcl@users.noreply.github.com>
@hardillb @Steve-Mcl
Update frontend/src/pages/device/index.vue
f13ec23 
Co-authored-by: Stephen McLaughlin <44235289+Steve-Mcl@users.noreply.github.com>
@hardillb @Steve-Mcl
Update frontend/src/pages/device/components/DeviceLog.vue
6318cbe 
Co-authored-by: Stephen McLaughlin <44235289+Steve-Mcl@users.noreply.github.com>
@hardillb
Merge branch 'main' into device-logs
1f4f195
@hardillb
Fix to new lint standards
365bf10
@Steve-Mcl Steve-Mcl self-requested a review April 4, 2023 09:22
@hardillb hardillb marked this pull request as ready for review April 4, 2023 09:27
Steve-Mcl
Steve-Mcl approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the couple of comments - good to go.

@hardillb @Steve-Mcl
Update frontend/src/pages/device/components/DeviceLog.vue
2d01c0f 
Co-authored-by: Stephen McLaughlin <44235289+Steve-Mcl@users.noreply.github.com>
hardillb
hardillb commented Apr 4, 2023
View reviewed changes
frontend/src/api/devices.js Outdated Show resolved Hide resolved
@Steve-Mcl @hardillb
Update frontend/src/pages/device/components/DeviceLog.vue
bc418e1 
Co-authored-by: Ben Hardill <ben@flowforge.com>
Steve-Mcl and others added 4 commits April 4, 2023 14:36
@Steve-Mcl @hardillb
Update frontend/src/pages/device/components/DeviceLog.vue
6883f0f 
Co-authored-by: Ben Hardill <ben@flowforge.com>
@Steve-Mcl @hardillb
Update frontend/src/api/devices.js
89b7347 
Co-authored-by: Ben Hardill <ben@flowforge.com>
@Steve-Mcl
remove unused (linting)
3bc1e21
@hardillb @Steve-Mcl
Update frontend/src/pages/device/Logs.vue
da3e862 
Co-authored-by: Stephen McLaughlin <44235289+Steve-Mcl@users.noreply.github.com>
@Steve-Mcl Steve-Mcl self-requested a review April 4, 2023 13:45
Steve-Mcl
Steve-Mcl approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me. Will merge once tests complete.

@Steve-Mcl Steve-Mcl merged commit bc396b9 into main Apr 4, 2023
@Steve-Mcl Steve-Mcl deleted the device-logs branch April 4, 2023 14:59
@hardillb hardillb mentioned this pull request Apr 13, 2023
Closed
@knolleary knolleary linked an issue Apr 13, 2023 that may be closed by this pull request
Access Node-RED log output from device agent #1820
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steve-Mcl Steve-Mcl Steve-Mcl approved these changes

Assignees

@hardillb hardillb

Labels
None yet
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.

Access Node-RED log output from device agent
2 participants
@hardillb @Steve-Mcl