-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Applications Table #1903
Conversation
# Conflicts: # frontend/src/pages/application/Settings.vue # frontend/src/pages/device/Overview.vue # frontend/src/pages/instance/index.vue # frontend/src/pages/project/index.vue # frontend/src/pages/team/Applications.vue # frontend/src/pages/team/routes.js
Dev'd up the alternative view, it uses up a lot more vertical space, but think it breaks down the hierarchy better. This is quite an unlikely scenario, where they have 6 different applications, and only one instance in each, vertical space is used more effectively for multiple instance within a given application due to where the padding lives. In both scenarios, the duplication of Instance/Application name makes it trickier to digest too Screen.Recording.2023-03-30.at.18.28.45.mov |
This shouldn't apply any more, create new instances in your applications and delete the ones with the duplicate names (and/or create new applications). |
Appreciate that - didn;t see an API (exposed in the |
Renaming is not available yet, create new ones! The API is there for it though, see the application route on the backend. It's set as a follow up on #1735 |
If the API is there (I'll go digging in a second) - I'll just add it front-end - 10 mins of work. |
…nto feat-1851-applications-table # Conflicts: # test/unit/forge/ee/lib/billing/trialTask_spec.js
…nto feat-1851-applications-table
All development work now done - just tests remaining which I will get to next week (Tuesday) |
@joepavitt after the other branches merged to main, I will do a rebase and then review this branch |
This has a merge from Alternatively, we can switch this PR to point to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed my comments since Joe is out
Description
Correct me if this isn't the branch to be PRing back into @Pezmc. This also includes a merge of
main
so I could get the other UI work I'd done, hence the ridiculous number of files changed and commits, not sure how best to coordinate branches here, I can continue to pull updates from your feat-1735-expose-applications branch and then this PR could be the primary merge tomain
?Updates:
Still to do:
/applications/<application-id>/instances
API endpoint.Related Issue(s)
Closes #1851
Checklist