-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Add file extensions to all imports #1910
Conversation
aacfb7c
to
b1b1fca
Compare
@Pezmc do you have 2 mins to discuss this PR please? |
@@ -417,160 +393,6 @@ | |||
"frontend/src/components/icons/nodered-hex.svg" | |||
] | |||
}, | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tidy up bad eslint config! These lines are turning off the null
rule, which wasn't doing anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following a review of the changes and a quick chat with @Pezmc I am personally very happy happy to see this work merged.
Description
See discussion in #1908.
Skipping file extensions is a web pack feature that's scheduled to be removed from standard ES modules.
In the new ES modules proposal file extensions are mandatory in import statements.
Being explicit, also enables better static code analysis, performed by tools like VSCode and ESLint
This PR:
Related Issue(s)
#1908
Checklist
flowforge.yml
?flowforge/helm
to update ConfigMap Templateflowforge/CloudProject
to update values for Staging/ProductionLabels
backport
labelarea:migration
label