Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the "Open Editor" button if Instance not "running" #1933

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

joepavitt
Copy link
Contributor

Description

I don't believe there are any states where we'd want to open the editor, other than, when the Instance is "running". As such, even though #1931 specifies blocking on "starting" this change blocks on all states, except for "running"

Related Issue(s)

Fixes #1931

Checklist

@joepavitt joepavitt requested a review from Pezmc April 7, 2023 09:30
@Pezmc Pezmc merged commit e1e4707 into main Apr 11, 2023
@Pezmc Pezmc deleted the 1931-disable-open branch April 11, 2023 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application Overview: “Open Editor” shouldn’t show (or should be disabled) if in “Starting” state
2 participants