Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Stripe redirect & add holding message #1959

Merged
merged 4 commits into from
Apr 12, 2023
Merged

Conversation

joepavitt
Copy link
Contributor

Description

  • Directs users to /applications instead of /overview which no longer exists
  • Adds a holding message which is very unlikely to be seen, as they join in trial, and setup an Application (for free) as part of the onboarding, but it's nice to be nice just in case this state does arise.

Screenshot 2023-04-11 at 18 45 46

Related Issue(s)

Close #1955

Checklist

@joepavitt
Copy link
Contributor Author

I've seen this test failing randomly on a few occasions now, it should be resolved and fixed properly. Will open a separate PR for it.

⎯⎯⎯⎯⎯⎯⎯ Failed Tests 1 ⎯⎯⎯⎯⎯⎯⎯

 FAIL  test/unit/frontend/utils/elapsedTime.spec.js > elapsedTime > compares relative to now if only a to date is passed
AssertionError: expected '30 minutes, 14 seconds' to be '30 minutes, 15 seconds' // Object.is equality
 ❯ test/unit/frontend/utils/elapsedTime.spec.js:58:35
     56|         soon.setSeconds(soon.getSeconds() + 15)
     57| 
     58|         expect(elapsedTime(soon)).toBe('30 minutes, 15 seconds')
       |                                   ^
     59|     })
 Test Files  1 failed | 7 passed (8)
     60| 
      Tests  1 failed | 56 passed (57)

   Start at  17:49:42
  - Expected  - 1
   Duration  9.78s (transform 673ms, setup 1ms, collect 1.29s, tests 333ms, environment 4.48s, prepare 946ms)
  + Received  + 1


  - '30 minutes, 15 seconds'
  + '30 minutes, 14 seconds'
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯

@@ -187,6 +195,9 @@ export default {
id: instance.id
}
})
},
async checkBillingSession () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
async checkBillingSession () {
checkBillingSession () {

@@ -187,6 +195,9 @@ export default {
id: instance.id
}
})
},
async checkBillingSession () {
this.justSetupBilling = 'billing_session' in this.$route.query
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a computed property

@Pezmc Pezmc merged commit bd6f17a into main Apr 12, 2023
@Pezmc Pezmc deleted the 1955-stripe-redirect branch April 12, 2023 03:31
@knolleary
Copy link
Member

Adds a holding message which is very unlikely to be seen, as they join in trial, and setup an Application (for free) as part of the onboarding, but it's nice to be nice just in case this state does arise.

Setting up an application isn't part of onboarding. We setup the team for them without billing. If they choose to configure billing before they create their trial application then they will see this message.

They will also see this message if they choose to create a second team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirect back from Stripe takes you to 404 page
3 participants