-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Stripe redirect & add holding message #1959
Conversation
I've seen this test failing randomly on a few occasions now, it should be resolved and fixed properly. Will open a separate PR for it.
|
@@ -187,6 +195,9 @@ export default { | |||
id: instance.id | |||
} | |||
}) | |||
}, | |||
async checkBillingSession () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
async checkBillingSession () { | |
checkBillingSession () { |
@@ -187,6 +195,9 @@ export default { | |||
id: instance.id | |||
} | |||
}) | |||
}, | |||
async checkBillingSession () { | |||
this.justSetupBilling = 'billing_session' in this.$route.query |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a computed property
Setting up an application isn't part of onboarding. We setup the team for them without billing. If they choose to configure billing before they create their trial application then they will see this message. They will also see this message if they choose to create a second team. |
Description
/applications
instead of/overview
which no longer existsRelated Issue(s)
Close #1955
Checklist