Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Instances: Application Audit Log Events #1979

Merged
merged 3 commits into from
Apr 13, 2023

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented Apr 13, 2023

Description

Adds Team Level only application events (create/update/delete).

See #1978 for work to add application level events.

Related Issue(s)

Fixes #1935

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • [-] Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backend code and frontend logic looks fine. gets my approval.
Will not merge as should be reviewed by @joepavitt for UI aspect

@Steve-Mcl
Copy link
Contributor

Steve-Mcl commented Apr 13, 2023

@Pezmc @joepavitt

I note in the audit loggers, the project object is still named project. Is this something we will have to live with or will project object also be renamed (something like appInstance or nodeRedInstance)?

@Pezmc
Copy link
Contributor Author

Pezmc commented Apr 13, 2023

@Steve-Mcl Thanks for the review, it's likely that they can be renamed as part of #1978, but for now we're keeping the old name to avoid database migrations etc to support it as instance.

@knolleary knolleary merged commit d0dbe8a into main Apr 13, 2023
@knolleary knolleary deleted the feat-1935-audit-log-entries branch April 13, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit log entries for applications (create/update/delete)
4 participants