Reduce forge app reinitialisation in model tests #2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knolleary
force-pushed
the
2004-reword-model-tests
branch
from
212b3e4
to
7104f5a
Compare
|
I've rebased on |
|
Fixed the postgres failure - hoping they run clean now |
|
Postgres failed with a genuine error - not OOM. Must be a race condition as the normal tests passed. Will investigate |
knolleary
force-pushed
the
2004-reword-model-tests
branch
from
cf4f4f2
to
05e0558
Compare
|
I've rebased on main again - this time picking up the latest updates on the spec file that was failing on postgres. |
|
ok - postgres got past the previous point of failure then hit the OOM. I think that's as good as we can get right now. @Steve-Mcl all clear for you to review/merge |
|
@knolleary "JavaScript heap out of memory" this time. Are you happy for me to proceed with review? DOH. Ignore. Just spotted your comment above 🤦♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2004
Reduces forge app reinit under
test/unit/forge/db/models/Not as productive as the controller test changes simply due to the smaller number of tests involved.