Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor more tests to minimise forge app initialisation #2025

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

knolleary
Copy link
Member

Part of #2004

More tests refactored.

  • test/unit/forge/ee/routes/billing/index_spec.js
  • test/unit/forge/routes/api/application_spec.js
  • test/unit/forge/ee/routes/sharedLibrary/index_spec.js

Reduced 50s to 10s

@Steve-Mcl
Copy link
Contributor

An odd failure in this one Nick.

At a quick glance, it looks like an edge case rounding error?

@knolleary
Copy link
Member Author

@Steve-Mcl I've rerun and they have passed up to the point of memory failure.

The previous error must be a timing thing - but in a completely unrelated test. Not sure we've seen it much if at all. As it is unrelated to this PR, I'm happy to move forward as is.

@Steve-Mcl
Copy link
Contributor

Not sure we've seen it much if at all. As it is unrelated to this PR, I'm happy to move forward as is.

Agreed and it is a fairly benign issue (what is one second dfif in a time duration string - in the grand scheme of things)

Happy to proceed.

@Steve-Mcl Steve-Mcl merged commit 6b2c57d into main Apr 21, 2023
@Steve-Mcl Steve-Mcl deleted the 2004-even-more-tests branch April 21, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants