-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restore rollbackSnapshot #2030
restore rollbackSnapshot #2030
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment around renaming, but not going to block!
@Pezmc could you please pick up the TODO if I raise an issue? |
Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
@Steve-Mcl What todo are you planning to open? |
@Pezmc the TODO is the fact this PR has no unit test to cover the new api being added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a basic happy path E2E acceptance test to ensure rollback instance is working and we don't his this regression again, happy to help write it if needed!
Will raise "Ensure the "missing Done: #2032 |
@Steve-Mcl @knolleary And I spoke in a Huddle, happy for this PR to move forward now so we can backport a fix, but we must address #2032 as a follow up. |
restore rollbackSnapshot (backport #2030)
fizes #2026
Description
restore rollbackSnapshot
TODO
rollbackSnapshot
function" is caught in an API test to prevent regression #2032Related Issue(s)
#2026
Acceptance
Checklist
rollbackSnapshot
function" is caught in an API test to prevent regression #2032flowforge.yml
?flowforge/helm
to update ConfigMap Templateflowforge/CloudProject
to update values for Staging/ProductionLabels
backport
labelarea:migration
label