Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore rollbackSnapshot #2030

Merged
merged 3 commits into from
Apr 24, 2023
Merged

Conversation

Steve-Mcl
Copy link
Contributor

@Steve-Mcl Steve-Mcl commented Apr 24, 2023

fizes #2026

Description

restore rollbackSnapshot

TODO

Related Issue(s)

#2026

Acceptance

  • Test operation on staging before updating prod

Checklist

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl Steve-Mcl linked an issue Apr 24, 2023 that may be closed by this pull request
Copy link
Contributor

@Pezmc Pezmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment around renaming, but not going to block!

@Steve-Mcl
Copy link
Contributor Author

@Pezmc could you please pick up the TODO if I raise an issue?

frontend/src/api/instances.js Outdated Show resolved Hide resolved
Steve-Mcl and others added 2 commits April 24, 2023 09:57
@Pezmc
Copy link
Contributor

Pezmc commented Apr 24, 2023

@Steve-Mcl What todo are you planning to open?

@knolleary
Copy link
Member

@Pezmc the TODO is the fact this PR has no unit test to cover the new api being added.

Copy link
Contributor

@Pezmc Pezmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a basic happy path E2E acceptance test to ensure rollback instance is working and we don't his this regression again, happy to help write it if needed!

@Steve-Mcl
Copy link
Contributor Author

Steve-Mcl commented Apr 24, 2023

This needs a basic happy path E2E acceptance test to ensure rollback instance is working and we don't his this regression again, happy to help write it if needed!

Will raise

"Ensure the "missing rollbackSnapshot function" is caught in an API test to prevent regression"

Done: #2032

@Pezmc
Copy link
Contributor

Pezmc commented Apr 24, 2023

@Steve-Mcl @knolleary And I spoke in a Huddle, happy for this PR to move forward now so we can backport a fix, but we must address #2032 as a follow up.

@knolleary knolleary merged commit 9865d05 into main Apr 24, 2023
3 checks passed
@knolleary knolleary deleted the 2026-snapshot-rollback-no-longer-working branch April 24, 2023 13:44
knolleary added a commit that referenced this pull request Apr 24, 2023
restore rollbackSnapshot (backport #2030)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

snapshot rollback no longer working
3 participants