-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add access token support to stats endpoint #2053
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pezmc
reviewed
Apr 28, 2023
Pezmc
reviewed
Apr 28, 2023
Pezmc
reviewed
Apr 28, 2023
Pezmc
reviewed
Apr 28, 2023
Co-authored-by: Pez Cuckow <email@pezcuckow.com>
Co-authored-by: Pez Cuckow <email@pezcuckow.com>
Co-authored-by: Pez Cuckow <email@pezcuckow.com>
Co-authored-by: Pez Cuckow <email@pezcuckow.com>
Pezmc
reviewed
May 3, 2023
Pezmc
approved these changes
May 3, 2023
Co-authored-by: Pez Cuckow <email@pezcuckow.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2043
Description
This PR adds the ability to monitor the platform from tools such prometheus.
It has ended up touching lots of files, but I have structured the commits to make it easier to review.
Highlevel description:
Commits in order:
verifyAdmin
as a catch-all preHandler to ensure a request comes from an admin. But to support tokens with reduced scope, we cannot do that. So I've added explicitlyneedsPermission
preHandler to all admin routes. To go alongside this, I've added much better Unit Test coverage ofneedsPermission
to cater for the growing number of scenarios.accept
header requests itChecklist
flowforge.yml
?flowforge/helm
to update ConfigMap Templateflowforge/CloudProject
to update values for Staging/ProductionLabels
backport
labelarea:migration
label