Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure instance logs refresh after unsuspending an instance #2085

Merged
merged 1 commit into from
May 5, 2023

Conversation

knolleary
Copy link
Member

Fixes #2083

Description

The logs view was clearing the refresh interval when an instance was in suspended state. However if the instance came out of suspended state it wasn't restoring the refresh interval so the logs would never update.

This keeps the interval running all the time the view is mounted - but only polls for logs if the state is not suspended.

It also clears the log history when we detect the instance is suspended; with the existing behaviour, when you suspended then started an instance the previous logs would be shown for a couple of seconds whilst it retrieved the new logs.

Related Issue(s)

#2083

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@knolleary knolleary requested a review from Pezmc May 4, 2023 09:01
@Pezmc Pezmc merged commit 8b48e24 into main May 5, 2023
2 checks passed
@Pezmc Pezmc deleted the 2083-ensure-logs-keep-updating branch May 5, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InstanceLogs component doesn't resume polling after instance leaves suspended state
2 participants