Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deviceEditor feature flag in place of license check #2118

Merged
merged 1 commit into from
May 10, 2023

Conversation

knolleary
Copy link
Member

Description

The existing license check only works for admin users as regular uses don't get visibility of that setting.

This PR switches over to a deviceEditor feature flag which is how we manage access to licensable features elsewhere in the UI.

@knolleary knolleary requested a review from Steve-Mcl May 10, 2023 10:27
Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@knolleary knolleary merged commit 4cb34d6 into main May 10, 2023
4 checks passed
@knolleary knolleary deleted the fix-dev-mode-perms branch May 10, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants