Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update install-stack.js #2139

Merged
merged 1 commit into from
May 15, 2023
Merged

Update install-stack.js #2139

merged 1 commit into from
May 15, 2023

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented May 14, 2023 •
edited
Loading

#fixes #2138

Description

Path to install stack may contain spaces, need to wrap in quotes to prevent space being interpreted as gap in arguments.

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb requested a review from Steve-Mcl May 14, 2023 07:50
@hardillb hardillb self-assigned this May 14, 2023
@hardillb hardillb added this to the 1.8 milestone May 14, 2023
@knolleary knolleary self-requested a review May 15, 2023 13:40
@knolleary knolleary merged commit fd83e19 into main May 15, 2023
2 checks passed
@knolleary knolleary deleted the hardillb-patch-2 branch May 15, 2023 13:40
@github-actions github-actions bot mentioned this pull request May 15, 2023
Merged
11 tasks
knolleary added a commit that referenced this pull request May 15, 2023
@knolleary
Merge pull request #2148 from flowforge/backport-2139
fada307 
Update install-stack.js (backport #2139)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knolleary knolleary knolleary approved these changes

@Steve-Mcl Steve-Mcl Awaiting requested review from Steve-Mcl

Assignees

@hardillb hardillb

Labels
backport
Projects
None yet
Milestone
1.8
2 participants
@hardillb @knolleary