Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipelines: Edit and Update #2158

Merged
merged 15 commits into from
May 22, 2023
Merged

Pipelines: Edit and Update #2158

merged 15 commits into from
May 22, 2023

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented May 20, 2023 •
edited
Loading

Description

Merges into #2075

Description

Adds edit and delete of pipeline stages (with no inbuilt remapping).

Screen.Recording.2023-05-21.at.21.40.23.mov

Related Issue(s)

#2124

Checklist

  • I have read the contribution guidelines
  • [-] Suitable unit/system level tests have been added and they pass - Test coverage in main branch
  • [-] Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • [-] Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • [-] Backport needed? -> add the backport label
  • [-] Includes a DB migration? -> add the area:migration label

@Pezmc Pezmc marked this pull request as ready for review May 21, 2023 12:36
@Pezmc Pezmc requested a review from joepavitt May 21, 2023 12:38
@Pezmc Pezmc requested a review from knolleary May 22, 2023 03:53
This was referenced May 22, 2023
Closed
Closed
Closed
Closed
This was linked to issues May 22, 2023
Pipelines: UI support for edit stage #2159
Closed
Pipelines: Don't allow selecting an instance that's already in use #2160
Closed
Pipelines: UI support for deleting stages #2161
Closed
Pipelines: API support for edit stage #2163
Closed
Pipelines: API support for deleting stages #2166
Closed
@Pezmc Pezmc merged commit d543880 into 2075-application-pipelines May 22, 2023
4 checks passed
@Pezmc Pezmc deleted the 2124-edit-pipeline branch May 22, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knolleary knolleary knolleary approved these changes

@joepavitt joepavitt Awaiting requested review from joepavitt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Pezmc @knolleary