Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve env variable editing uxp #2175

Merged
merged 5 commits into from
May 26, 2023
Merged

Improve env variable editing uxp #2175

merged 5 commits into from
May 26, 2023

Conversation

Steve-Mcl
Copy link
Contributor

Description

  • Ensure save button is disabled/enabled accordingly
  • Prompt user upon navigation if there are unsaved changes
  • update existing toast on instance edit - to inform user of when changes will be applied (as per @MarianRaphael request)
  • add toast to device env var editing (to match instance env var editing) - to inform user of success and when the changes will be applied (as per @MarianRaphael request)

Related Issue(s)

#1646

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl
Copy link
Contributor Author

@MarianRaphael requested your review in absence of Joe and Pez. Feel free to re-assign.

@Steve-Mcl Steve-Mcl linked an issue May 23, 2023 that may be closed by this pull request
Autosaving Env Vars #1646
Closed
MarianRaphael
MarianRaphael approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@MarianRaphael MarianRaphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but let's wait for Pez's review

@MarianRaphael MarianRaphael requested a review from Pezmc May 24, 2023 06:37
@Steve-Mcl
Copy link
Contributor Author

@Pezmc, to assist review, refer to the parent issue for implementation notes and screenshots

Pezmc
Pezmc approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@Pezmc Pezmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments, looks good overall!

@Steve-Mcl Steve-Mcl merged commit 39f1d63 into main May 26, 2023
2 checks passed
@Steve-Mcl Steve-Mcl deleted the 1646-Autosaving-Env-Vars branch May 26, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pezmc Pezmc Pezmc approved these changes

@MarianRaphael MarianRaphael MarianRaphael approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autosaving Env Vars
3 participants
@Steve-Mcl @Pezmc @MarianRaphael