Add shared subscriptions to broker ACL for project nodes #2225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In draft to get eyes on the code earlier - still need to do some further validation before this can be merged. |
|
@Steve-Mcl ready for review - tested with updated projects nodes. Will have a PR with those updates shortly. |
This was referenced Jun 5, 2023
|
@Steve-Mcl this side is good to review and merge so we can get onto staging. The outstanding work is in the project nodes. |
|
Will do as my next task (aprox 10 mins) |
Steve-Mcl
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #2156
See also FlowFuse/nr-project-nodes#28
Adds support for using shared subscription topics on certain project-node topics.
Given we need to support both shared and non-shared versions of the topics, rather than copy/paste the rules, this adds a flag to indicate a topic can be handled as either plain or shared.
The share group id is required to the project/instance id.
It also adds a new rule for the response topic, to provide the ability for individual replicas to have a randomly generated component of the response topic.
Checklist