Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show error if trying to start the editor on device #2234

Merged
merged 3 commits into from
Jun 6, 2023
Merged

Show error if trying to start the editor on device #2234

merged 3 commits into from
Jun 6, 2023

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented Jun 6, 2023

part of #2233

Description

Should show and error to the user when trying to start the device editor if editor is not running.

Related Issue(s)

#2233

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb added this to the 1.8 milestone Jun 6, 2023
@hardillb hardillb requested a review from knolleary June 6, 2023 09:56
@hardillb hardillb self-assigned this Jun 6, 2023
@hardillb
Add pop up about trying to access editor while stopped
6a26981 
Now shows toast if device it not in running state
@hardillb
Copy link
Contributor Author

hardillb commented Jun 6, 2023

I've re-run the postgres test 3 times and it's OOMing all the time

@knolleary
Copy link
Member

I've added a bit to disable the 'enable/disable' editor button if the state isn't 'running'.

@knolleary
Copy link
Member

Once tests passing (OOM aside) we can merge.

@knolleary knolleary merged commit c3dd8fb into main Jun 6, 2023
4 checks passed
@knolleary knolleary deleted the 2233-disable-editor-if-not-running branch June 6, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knolleary knolleary knolleary approved these changes

Assignees

@hardillb hardillb

Labels
None yet
Projects
None yet
Milestone
1.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hardillb @knolleary