-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipelines: Server side deployment state tracking #2283
Conversation
@joepavitt Would appreciate some click testing from you to verify the UI still behaves as you expect! |
Didn't work for existing pipeline I had, but creating a new pipeline worked at first whilst in "installing", but my local seems to be getting stuck in "starting" again. Also notice that the polling doesn't seem to be enabled upon refresh? If I click "play" and then immediately refresh, has some instances where the target stage stay locked in "Installing" until I refreshed again. |
@joepavitt Looks like I hadn't pushed my latest 🤦 , will do a sanity check and retag you! Sorry for wasted time! |
This shouldn't happen, but the page shouldn't break if it does
@joepavitt Ready for a re-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done some clicking around, all appears functional. Refreshing the page, getting the inflight state updated properly. All good.
The only thing that caught me out was what lead me to raise #2332 as I thought things weren't updating properly. But that's (quite literally) a separate issue. |
Have managed to get my local up and running again for a couple of days blocked. Will try and get to this review this afternoon as I'm trying to round up the Dashboard work. If Nick is happy though, feel free to proceed @Pezmc |
Description
Split into two parts:
Key advantages:
Screen.Recording.2023-06-14.at.15.28.35.mov
Related Issue(s)
N/a
Checklist
flowforge.yml
?flowforge/helm
to update ConfigMap Templateflowforge/CloudProject
to update values for Staging/ProductionLabels
backport
labelarea:migration
label