Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show premium feature pages - even when feature is not available #2290

Merged
merged 12 commits into from
Jun 27, 2023

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented Jun 15, 2023

Description

Draft as pending UX/UI polish from @joepavitt and test coverage.

Screenshot 2023-06-15 at 14 50 08 Screenshot 2023-06-15 at 14 50 03

Related Issue(s)

#2103

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@Pezmc Pezmc requested a review from joepavitt June 15, 2023 12:53
@joepavitt
Copy link
Contributor

@MarianRaphael any thoughts on where we'd like the "upgrade" text to link to? This will only show in self-hosted FF, and upgrading to Premium, if I'm not mistaken, can only be done via contacting us directly right now?

@MarianRaphael
Copy link
Contributor

I would provide a link to the documentation: https://flowforge.com/docs/upgrade/open-source-to-premium/. Additionally, on the documentation page, I would note that customers need to contact us to purchase a premium licence.

@joepavitt
Copy link
Contributor

Ended up changing the bg-color to blue-100 just to make it stand out a little more, as found it was washed into the b/g with the grey.

Screenshot 2023-06-27 at 10 41 17

Have also added the "upgrade" link.

@joepavitt joepavitt marked this pull request as ready for review June 27, 2023 12:52
Copy link
Contributor

@joepavitt joepavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have made some minor adjustments (banner colour and fixing E2E tests), all good to go

@joepavitt joepavitt merged commit 592ed4f into main Jun 27, 2023
3 checks passed
@joepavitt joepavitt deleted the feat-2103-show-premium-feature-pages branch June 27, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants