Guard against a container not existing and still allow removal #2307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardillb
approved these changes
Jun 16, 2023
knolleary
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I ran against this issue locally where removal failed half way through (removed from docker but not FlowForge).
This then left my account in a state where I could not delete the instance as it had already been removed from docker.
It's unlikely this would happen in production, but adding a guard just in case doesn't hurt!
Related Issue(s)
None
Checklist
flowforge.yml?flowforge/helmto update ConfigMap Templateflowforge/CloudProjectto update values for Staging/ProductionLabels
backportlabelarea:migrationlabel