Remove overloading of /api/v1/teams endpoint #2345
Merged
+107
−43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
/api/v1/teams
endpoint served two purposes:admin
, return a paginated list of teams on the platform?slug=<slug>
is provided, provide details of the corresponding team - with the appropriate ACL checksThis overloading is not nice when it comes to documenting the API. This PR cleans things up by introducing a separate endpoint to get a team by its slug:
/api/v1/teams/slug/:teamSlug
.Added unit test coverage of the new endpoint; the previous version was not explicitly covered.
Checklist
flowforge.yml
?flowforge/helm
to update ConfigMap Templateflowforge/CloudProject
to update values for Staging/ProductionLabels
backport
labelarea:migration
label