Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to flowforge.com for easier navigation to our website. #2347

Merged
merged 3 commits into from
Jul 4, 2023

Conversation

iskerrett
Copy link
Contributor

Description

Added links to flowforge.com to make it easier for people to navigate to our website.

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

README.md Outdated
@@ -1,5 +1,7 @@
# FlowForge

https://flowforge.com/
Copy link
Contributor

@Pezmc Pezmc Jun 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me, this floating at the top of the readme docs on GitHub looks out of place.

GitHub has an inbuilt repository about section, that's likely a better place for this:

Screenshot 2023-06-27 at 15 58 00

Someone with the correct GitHub permissions can add the link.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few places we can add the link... but having it in the readme is important (aside from exact placement etc) as that will also end up on the npm page for our package - https://www.npmjs.com/package/@flowforge/flowforge

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On NPM we could also update the website field to actually point to the website. I believe that's pulled from package.json's homepage field.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the github website field (and added node-red and low-code keywords)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the homepage field and added the company logo as the link to the homepage in the readme.

@knolleary knolleary merged commit d63bf9e into main Jul 4, 2023
4 checks passed
@knolleary knolleary deleted the iskerrett-patch-1 branch July 4, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants