Add schemas to device api routes #2357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
Pezmc
approved these changes
Jun 29, 2023
Add schemas to admin/settings/stack routes
Add schemas to Template, Types and UserInvitation routes
Add schemas to all teamDevices routes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1556
This targets the branch of #2356
This PR adds schemas to
routes/api/device.jsAlong the way I found one route that had a test looking for the built-in required params validation error message. However, for reasons, having applied the schema the response format is different and doesn't provide the useful error message about what has failed.
As it stands, I haven't been setting the
requiredflag on any schema consistently - some already had it. We'll want to do a second pass through and tidy that up - including getting the error response object to contain useful information in a useful structure.https://fastify.dev/docs/latest/Reference/Validation-and-Serialization/#error-handling covers a lot of it.