Allow filtering of Node-RED logs when in HA mode #2367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Functionally, all looks good. Does need E2E test though, but I'll cover them now @hardillb. Having to pull in |
|
@joepavitt I've just pushed a tiny update to insert the src markers into the stub drivers fake log output that should help with the tests |
|
Thanks Ben, was stubbing the API responses with the |
joepavitt
reviewed
Jun 30, 2023
| it('display a marker to indicuate with HA replica the logs are from, if present', () => { | ||
| // Modify our Instance so that HA is enabled | ||
| cy.intercept('GET', '/api/*/projects/*', (req) => { | ||
| req.continue((res) => { |
There was a problem hiding this comment.
@Pezmc TIL about req.continue() to modify a response in Cypress, rather than mock up a full response, came in real handy here, and flagging in case you'd not seen it before.
joepavitt
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #2260
Description
Allows filtering of logs for HA instances to only show logs from a single replica
Related Issue(s)
#2260
Checklist
flowforge.yml?flowforge/helmto update ConfigMap Templateflowforge/CloudProjectto update values for Staging/ProductionLabels
backportlabelarea:migrationlabel