Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple stream access to device logs #2374

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Support multiple stream access to device logs #2374

merged 1 commit into from
Jun 30, 2023

Conversation

knolleary
Copy link
Member

Fixes FlowFuse/device-agent#126

Description

This fixes issues around concurrent access to device logs from multiple pages.

  • it keeps track of the individual websocket connections and ensures logs are forwarded to them all
  • it keeps a local cache of the last 10 events so when a new connection arrives it can be provided some history.
  • adds unit test coverage for this whole area

Checklist

@knolleary knolleary requested a review from hardillb June 30, 2023 10:52
@hardillb
Copy link
Contributor

Will merge once test finish

@hardillb hardillb merged commit 553ea3b into main Jun 30, 2023
3 checks passed
@hardillb hardillb deleted the da126-parallel-device-log-access branch June 30, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardillb hardillb hardillb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Device logs become unavailable if more than one browser views them
2 participants
@knolleary @hardillb