Add FF_SNAPSHOT_ID to devices #2377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nick, should we not include the snapshot name and description? Similar to how the device name and type are be used in flows to "do something else" I can foresee similar requirements around snapshot. And while that can be achieved with the ID, it provides no context to the user. |
hardillb
approved these changes
Jul 3, 2023
|
@knolleary - I see Ben has approved the changes but please read and comment on my suggestion (above, dated 30th Jun) before merging. |
|
@Steve-Mcl I think description is unnecessary, but a case could be made for name. Will add. |
|
@Steve-Mcl |
|
Thanks Nick. Reviewing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes FlowFuse/device-agent#94
Description
This adds
FF_SNAPSHOT_IDto the env passed down to devices. This is set to the id of the targetSnapshot for the device.Checklist