Improve instruction & labelling on "Add Device" dialog #2434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pezmc
approved these changes
Jul 7, 2023
Steve-Mcl
reviewed
Jul 12, 2023
| </FormRow> | ||
| <FormRow v-model="input.type" data-form="device-type" :error="errors.type" :disabled="editDisabled" container-class="w-full"> | ||
| <template #default>Type</template> | ||
| <template #description>Use this field to better identify your device, and sort/filter in your device list.</template> |
There was a problem hiding this comment.
The type field becomes much more useful at the edge:
For example, you might deploy the same flow to 2 physically different device types. The env var FF_DEVICE_TYPE can be used in switch nodes for routing messages, doing different things, accessing alternative edge connected things etc.
There was a problem hiding this comment.
didn't realise that FF_DEVICE_TYPE was an env var made available either. May be worth extending this description with something along those lines if you don't mind?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve the language & labelling on the "Add Device" modals. Better informing users of functionality available.
Related Issue(s)
Fixed #2428
Checklist
flowforge.yml?flowforge/helmto update ConfigMap Templateflowforge/CloudProjectto update values for Staging/ProductionLabels
backportlabelarea:migrationlabel