Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codecov reporting #2437

Merged
merged 3 commits into from
Jul 11, 2023
Merged

Add codecov reporting #2437

merged 3 commits into from
Jul 11, 2023

Conversation

knolleary
Copy link
Member

Description

This modifies our builds and npm actions to run code coverage reporting.

  • Main build action:
    • Removes the frontend unit tests as they are also run in the e2e action - we don't want to be reporting on them twice
    • Adds upload to codecov with the 'backend' tag applied
  • E2E build - updated
    • Adds upload to codecov with the 'frontend' tag applide
  • Updates vitest and adds the istanbul coverage reporter - needed for compatibility with the nyc reports.
  • Updates the cover:* actions to generating their coverage reports in a consistent location and renames them so they are individually identifiable. (nyc lets you pick the dir it'll write the json to, but no the name of the json file - so we have to do this dance to get the files from separate runs into the same dir without overwriting each other)

@knolleary knolleary requested a review from Pezmc July 7, 2023 15:00
@knolleary
Copy link
Member Author

Merging this PR will get a baseline of coverage stats into codecov. From then on, subsequent PRs should get a coverage report added.

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@183abd5). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2437   +/-   ##
=======================================
  Coverage        ?   38.87%           
=======================================
  Files           ?      489           
  Lines           ?    17078           
  Branches        ?     3955           
=======================================
  Hits            ?     6639           
  Misses          ?    10439           
  Partials        ?        0           
Flag Coverage Δ
backend 72.32% <0.00%> (?)
frontend 1.55% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Pezmc Pezmc merged commit 9dee4da into main Jul 11, 2023
6 checks passed
@Pezmc Pezmc deleted the add-codecov-reporting branch July 11, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants