-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Postgres DB connection to enable SSL #2500
Conversation
part of FlowFuse/helm#151 This should make sequelize try and connect with SSL first then fall back to plain.
Codecov Report
@@ Coverage Diff @@
## main #2500 +/- ##
==========================================
+ Coverage 1.55% 74.35% +72.80%
==========================================
Files 489 224 -265
Lines 17133 8852 -8281
Branches 3976 1823 -2153
==========================================
+ Hits 266 6582 +6316
+ Misses 16867 2270 -14597
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Tested the option with:
I have since shutdown the test cockroach db instance, but can spin up another free one if needed. |
OK, this isn't doing what the docs suggest it should, |
Adds `forge.db.ssl` as a boolean option
I've made this a simple toggle for now as the fallback options doesn't appear to have been implemented in the nodejs PG driver. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems sensible
part of FlowFuse/helm#151
This should make sequelize try and connect with SSL first then fall back to plain.
Description
This should make sequelize try and connect with SSL first then fall back to plain.
Shouldn't need a doc upgrade as this should "just work"
Likewise this shouldn't need a test change
Related Issue(s)
FlowFuse/helm#151
Checklist
flowforge.yml
?flowforge/helm
to update ConfigMap Templateflowforge/CloudProject
to update values for Staging/ProductionLabels
backport
labelarea:migration
label