Handle node-red log messages with undefined payloads #2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steve-Mcl
reviewed
Jul 21, 2023
Codecov Report
@@ Coverage Diff @@
## main #2515 +/- ##
==========================================
- Coverage 74.38% 1.55% -72.84%
==========================================
Files 224 489 +265
Lines 8855 17136 +8281
Branches 1822 3969 +2147
==========================================
- Hits 6587 266 -6321
- Misses 2268 16870 +14602
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Co-authored-by: Stephen McLaughlin <44235289+Steve-Mcl@users.noreply.github.com>
Steve-Mcl
approved these changes
Jul 21, 2023
knolleary
commented
Jul 21, 2023
knolleary
added a commit
that referenced
this pull request
Jul 25, 2023
Handle node-red log messages with undefined payloads (backport #2515)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Seen in production. Not clear how a log message could end up with this property - will investigate separately. But better to ensure it's handled in UI.