Copy InstanceType billing into default starter team type configuration #2533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2533 +/- ##
==========================================
- Coverage 39.84% 39.83% -0.02%
==========================================
Files 494 494
Lines 17690 17695 +5
Branches 4125 4126 +1
==========================================
Hits 7049 7049
- Misses 10641 10646 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
The postgres tests timeout - but appeared to still be running normally. So have increased the timeout for those tests to 45mins. |
Pezmc
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When creating the default starter team type, we need to ensure any existing instance type billing information is copied across. This ensures the billing information is correctly displayed.
This also hides the UI for setting the instance type billing information against the individual instance types - that has to be done at the team type level now.